Omer Frenkel has posted comments on this change.
Change subject: engine: Fetching cluster Id code moved from constructor to
canDoAction method.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 37: if (!super.canDoAction()) {
super.canDoAction() assuming cluster id already set, when checking for up
server, so need to overcome this
also, please make sure non of the following commands inheriting from this
command base doesn't assume the same, specially in getPermissionCheckSubject
that is called before canDoAction (this is why usually we initiate params in
the ctor)
--
To view, visit http://gerrit.ovirt.org/6365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I187f4fa678389dbbd271d487bbbf2b81e5c0080c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
