Mike Kolesnik has posted comments on this change.

Change subject: core: updating quota for snapshots
......................................................................


Patch Set 1: Do not submit

(1 inline comment)

....................................................
File backend/manager/dbscripts/images_sp.sql
Line 112:          it_guid = '00000000-0000-0000-0000-000000000000'; 
Please do not do this here, this method is general behaviour of updating an 
image entity, and also might be (and probably is) used in compensation logic.

--
To view, visit http://gerrit.ovirt.org/6307
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied75bf253bdb497a97d996f017d28fb2330d5ce6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to