Alexander Wels has posted comments on this change. Change subject: webadmin: 'Add Users and Groups' dialog the column size should be limited ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31260/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java: Line 144: }); Line 145: } Line 146: Line 147: private void initTable(CommonApplicationConstants constants) { Line 148: String width = "284px"; //$NON-NLS-1$ Can you make this a constant something like /** * This is the max width of a column in this dialogs */ private static final MAX_COL_WIDTH = "248px"; That way people understand what it is. Line 149: // Table Entity Columns Line 150: searchItems.addColumn(new EntityModelTextColumn<DbUser>() { Line 151: @Override Line 152: public String getText(DbUser user) { -- To view, visit http://gerrit.ovirt.org/31260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3009bffce854cc99031ad6571affea328c437d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
