Allon Mureinik has posted comments on this change. Change subject: core: Removing allow snapshot property from BaseDisk entity ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) see question inline. Also adding Ori to review REST issues. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java Line 53: return (!isShareable() && (getDiskStorageType() != DiskStorageType.LUN)); This infers that the base disk knows about the differences between LUNs and Images. Perhaps move this up to DiskImage and LunDisk? -- To view, visit http://gerrit.ovirt.org/6333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826eb81adf573d586408db21d71add7aaefb188c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
