Mike Kolesnik has posted comments on this change. Change subject: core: MAC address released when MAC is used (#839201) ......................................................................
Patch Set 2: (1 inline comment) Basically +2, just 1 minor comment .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java Line 35: private boolean isMacAddressChanged; Boolean naming convention is not to start with "is", just for the getters "is" is used instead of "get" since it makes more sense, but for fields convention is to just name the field as is, i.e. "macAddressChanged" -- To view, visit http://gerrit.ovirt.org/6331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb5109831cf1e290628e579add0ed060393b0d99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
