Greg Sheremeta has posted comments on this change.
Change subject: webadmin, userportal: WIP stop special handling of '@' in user
name
......................................................................
Patch Set 1:
Yes, but I'm asking about the scope -- where? everywhere, or just the login
page?
example from SetVmTicketCommand.java:
if (name.contains("@") ||
StringUtils.isEmpty(domain)) {
return name;
}
return name + "@" + domain;
Should this become simply
return name + "@" + domain;
?
--
To view, visit http://gerrit.ovirt.org/31792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7568c98c34e6edbd011949c5bad397aeba7b4ae
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
