Martin Peřina has uploaded a new change for review.

Change subject: core: Don't configure kdump when PM is disabled
......................................................................

core: Don't configure kdump when PM is disabled

Kudmp integration is enabled by default for new host. But there's no
sense to configure kdump integration without PM enabled. So this patch
disable kdump integration during host deploy if PM is disabled.

Change-Id: Ib05b2ce0ae512787f7b5d113f3a4ee1a1f05544b
Bug-Url: https://bugzilla.redhat.com/1126854
Signed-off-by: Martin Perina <mper...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/31801/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
index da81376..90442bd 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
@@ -581,7 +581,10 @@
             return true;
         }},
         new Callable<Boolean>() { public Boolean call() throws Exception {
-            if (_vds.isPmKdumpDetection() && !fenceKdumpSupported) {
+            boolean enabled = _vds.getpm_enabled() &&
+                    _vds.isPmKdumpDetection() &&
+                    fenceKdumpSupported;
+            if (!enabled) {
                 _messages.post(
                         InstallerMessages.Severity.INFO,
                         "Disabling Kdump integration"
@@ -590,7 +593,7 @@
 
             _parser.cliEnvironmentSet(
                     KdumpEnv.ENABLE,
-                    _vds.isPmKdumpDetection() && fenceKdumpSupported
+                    enabled
             );
             return true;
         }},


-- 
To view, visit http://gerrit.ovirt.org/31801
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib05b2ce0ae512787f7b5d113f3a4ee1a1f05544b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to