Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Add support to principal field in ui,rest-api, and 
built-in extension
......................................................................


Patch Set 6:

(1 comment)

in ui we should show principal instead of user name in user all over... in the 
generic ldap you will see now XXX\yyy

http://gerrit.ovirt.org/#/c/31413/6/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd:

Line 1965:           <xs:element name="namespace" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
Line 1966:           <xs:element name="last_name" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
Line 1967:           <!-- generally name@domain -->
Line 1968:           <xs:element name="user_name" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
Line 1969:           <xs:element name="principal_name" type="xs:string" 
minOccurs="0" maxOccurs="1"/>
I think principal should be suffieicent
Line 1970:           <xs:element name="password" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 1971:           <xs:element name="email" type="xs:string" minOccurs="0" 
maxOccurs="1"/>
Line 1972:           <!-- used only to represent the initial role assignments 
for a
Line 1973:                new user, therafter modification of role assignments 
are


-- 
To view, visit http://gerrit.ovirt.org/31413
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ba5d75449afd1ecdf75e7b335b4ab5cb32d10ce
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to