Arik Hadas has posted comments on this change. Change subject: core: New internal command, VmSlaPolicyCommand ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/27646/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java: Line 34: protected boolean canDoAction() { Line 35: if (getVdsGroup() == null) { Line 36: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_CLUSTER_CAN_NOT_BE_EMPTY); Line 37: } Line 38: if (!FeatureSupported.vmSlaPolicy(getVdsGroup().getcompatibility_version())) { can we fetch the compatibility version from the VM and not fetch the cluster? Line 39: return failCanDoAction(VdcBllMessages.VM_SLA_POLICY_NOT_SUPPORTED); Line 40: } Line 41: Line 42: if (getVm() == null) { Line 41: Line 42: if (getVm() == null) { Line 43: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_EXIST); Line 44: } Line 45: if (getVm().getStatus() != VMStatus.Up || getVm().getRunOnVds() == null) { no need for the second part (getVm().getRunOnVds() == null) Line 46: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL, Line 47: LocalizedVmStatus.from(getVm().getStatus())); Line 48: } Line 49: -- To view, visit http://gerrit.ovirt.org/27646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26b0794c52cfe1d352f26392a835023afcd9efa0 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
