Liron Aravot has posted comments on this change. Change subject: core: VdsUpdateRunTimeInfo - update device logical name ......................................................................
Patch Set 1: (1 comment) @Allon, the reason for that is that in case you have hosts from different version in the cluster, you'll get mixed results which might be irritating for the user. http://gerrit.ovirt.org/#/c/31733/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1251: Line 1252: Line 1253: private String getDeviceLogicalName(Map<?, ?> diskMapping, Guid deviceId) { Line 1254: String modifiedDeviceId = deviceId.toString().substring(0, 20); Line 1255: Map<?, ?> deviceMapping = (Map<?, ?>) diskMapping.get(modifiedDeviceId); > are you sure diskMapping can't be null? even if the host basically support it's always returned by vdsm as part of the list. Line 1256: return deviceMapping == null ? null : (String)deviceMapping.get(VdsProperties.Name); Line 1257: } Line 1258: Line 1259: /** -- To view, visit http://gerrit.ovirt.org/31733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08b13ba18ded824d7c62f72766fa7055da6ec49c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
