Michal Skrivanek has posted comments on this change. Change subject: core: update CPU QoS policy for running VMs ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/31631/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 579: new UpdateVmPolicyVDSParams(_vds.getId(), vmId, qos.getCpuLimit().intValue())); Line 580: } Line 581: } Line 582: } Line 583: }); > please move it to VdsEventListener (VdsEventListener#updateSlaPolicies(Coll or consider to really change it right now and remove the whole thing. On startup the initial set can be done directly in vdsm…the patch should be fairly simple over there and the change in API (just an addition) is small. VDSM maintainers will surely understand if it helps to eliminate an extra engine call in a critical VM phase Line 584: Line 585: // Refrain from auto-start HA VM during its re-run attempts. Line 586: _autoVmsToRun.removeAll(_vmsToRerun); Line 587: // run all vms that crushed that marked with auto startup -- To view, visit http://gerrit.ovirt.org/31631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia762ef4fc26cbfa913c077d34da51a9fa44946e8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
