Alon Bar-Lev has posted comments on this change.
Change subject: build: place proper name for jars/poms if package name modified
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File Makefile
Line 249: fi
OK.
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 585: %{_javadir}/%{name}
We have placed all at the same location before my changes, so I don't fully
understand what "own" is.... can you please explain what it is? doesn't this
result of the add_maven_depmap? is something wrong with the above loop?
I also expected to get a warning, but I did not get any, so I left this without
conditional.
What do you suggest?
--
To view, visit http://gerrit.ovirt.org/6341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae5434a00537892a21446f18c28b263683402d09
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
