[Engine-patches] Change in ovirt-engine[master]: restapi: support cpu qos limit

[juan . hernandez]

Juan Hernandez has posted comments on this change.

Change subject: restapi: support cpu qos limit
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.ovirt.org/#/c/31621/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java:

Line 34:             
model.setMaxReadThroughput(storageQos.getMaxReadThroughput());
Line 35:             
model.setMaxWriteThroughput(storageQos.getMaxWriteThroughput());
Line 36:             model.setMaxIops(storageQos.getMaxIops());
Line 37:             model.setMaxReadIops(storageQos.getMaxReadIops());
Line 38:             model.setMaxWriteIops(storageQos.getMaxWriteIops());
Do we need "break" here?
Line 39:         case CPU:
Line 40:             CpuQos cpuQos = null;
Line 41:             // avoid findbugs error.
Line 42:             if (entity instanceof CpuQos) {


Line 45:             // avoid findbugs error.
Line 46:             if (cpuQos == null) {
Line 47:                 return model;
Line 48:             }
Line 49:             model.setCpuLimit(cpuQos.getCpuLimit());
And here?
Line 50:         default:
Line 51:             break;
Line 52:         }
Line 53: 


Line 100:             }
Line 101:             if (model.isSetCpuLimit()) {
Line 102:                 ((CpuQos) entity)
Line 103:                         
.setCpuLimit(IntegerMapper.mapMinusOneToNull(model.getCpuLimit()));
Line 104:             }
A "break" here, even if it isn't strictly needed?
Line 105:         default:
Line 106:             break;
Line 107:         }
Line 108: 


-- 
To view, visit http://gerrit.ovirt.org/31621
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176f7d3e5776c515f09db94177eeb679e71412af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches