Sandro Bonazzola has uploaded a new change for review. Change subject: ux: add --include-sensitive-data ......................................................................
ux: add --include-sensitive-data Allow to avoid to obfuscate sensitive data like passwords, etc. Change-Id: I90458180d912db890fd91b16d7fd21e90d1fcec0 Bug-Url: https://bugzilla.redhat.com/1086942 Signed-off-by: Sandro Bonazzola <[email protected]> --- M src/__main__.py M src/engine-log-collector.8 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-log-collector refs/changes/13/31713/1 diff --git a/src/__main__.py b/src/__main__.py index bed8e42..1d8a9df 100755 --- a/src/__main__.py +++ b/src/__main__.py @@ -835,6 +835,9 @@ self._engine_plugin: 'sensitive_keys', 'ovirt_engine_dwh': 'dwh_sensitive_keys', } + if self.configuration['include_sensitive_data']: + for plugin in sensitive_keys: + self.configuration[sensitive_keys[plugin]] = ':' for plugin in sensitive_keys: if self.configuration.get(sensitive_keys[plugin]): @@ -1499,6 +1502,17 @@ default=tempfile.gettempdir() ) + parser.add_option( + "", "--include-sensitive-data", dest="include_sensitive_data", + action="store_true", default=False, + help=( + "Avoid to obfuscate sensitive data like passwords, etc." + "The generated archive will contain data considered sensitive " + "and its content should be reviewed by the originating " + "organization before being passed to any third party." + ) + ) + engine_group = OptionGroup( parser, "oVirt Engine Configuration", diff --git a/src/engine-log-collector.8 b/src/engine-log-collector.8 index 9ba8fa4..6bf4fd2 100644 --- a/src/engine-log-collector.8 +++ b/src/engine-log-collector.8 @@ -86,6 +86,13 @@ Destination directory where the report will be stored.\& +.IP "\fB\-\-include\-sensitive\-data\fP" + +Avoid to obfuscate sensitive data like passwords, etc. +The generated archive will contain data considered sensitive +and its content should be reviewed by the originating +organization before being passed to any third party. + .SH "oVirt Engine CONFIGURATION OPTIONS" The options in the oVirt Engine configuration group can be used to filter log collection from one or more hypervisors. If the \-\-no\-hypervisors option is specified, data is not collected from any hypervisor. Wild card globbing (*, ?, []) can be used to match names.\& -- To view, visit http://gerrit.ovirt.org/31713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90458180d912db890fd91b16d7fd21e90d1fcec0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
