Maor Lipchuk has posted comments on this change.

Change subject: restapi: Add REST API support for iSCSI multipathing
......................................................................


Patch Set 14:

(2 comments)

http://gerrit.ovirt.org/#/c/26225/14//COMMIT_MSG
Commit Message:

Line 22:        <name>{name}</name>
Line 23:        <storage_connection id="{storageconnection_id}" />
Line 24:        ...
Line 25:        <network id="{network_id}" />
Line 26:        ...
> Please use spaces instead of tabs
done
Line 27: </iscsi_bond>
Line 28: Updating an iSCSI Bond, only name and description can be editing that
Line 29: way:
Line 30: PUT /api/datacenters/{datacenter_id}/iscsibonds/{iscsibond_id}  
HTTP/1.1


http://gerrit.ovirt.org/#/c/26225/14/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterIscsiBondsResourceTest.java
File 
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterIscsiBondsResourceTest.java:

Line 13: import org.ovirt.engine.core.common.queries.IdQueryParameters;
Line 14: import org.ovirt.engine.core.common.queries.VdcQueryType;
Line 15: import org.ovirt.engine.core.compat.Guid;
Line 16: 
Line 17: public class BackendDataCenterIscsiBondsResourceTest extends 
AbstractBackendCollectionResourceTest<IscsiBond, 
org.ovirt.engine.core.common.businessentities.IscsiBond, 
BackendDataCenterIscsiBondsResource> {
This is the formatter output
Line 18:     protected static final Guid ISCSI_BOND_ID = GUIDS[1];
Line 19:     protected static final Guid DATA_CENTER_ID = GUIDS[2];
Line 20:     static Guid PARENT_GUID = GUIDS[2];
Line 21: 


-- 
To view, visit http://gerrit.ovirt.org/26225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8881110cbeb163e9fc09e98bf4497d894f40490
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to