Ravi Nori has posted comments on this change. Change subject: engine : CoCo: Add ability to register for audit log events ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/31639/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallBack.java: Line 10: Line 11: public CommandCallBack() {} Line 12: Line 13: public void executed(VdcReturnValueBase result) { Line 14: return; > Strange, i just noticed that, problably missed in previous reviews.. will change Line 15: } Line 16: Line 17: public void doPolling(Guid cmdId, List<Guid> childCmdIds) { Line 18: return; http://gerrit.ovirt.org/#/c/31639/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/AuditLogEvent.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/AuditLogEvent.java: Line 4: import org.ovirt.engine.core.common.businessentities.AuditLog; Line 5: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 6: import org.ovirt.engine.core.compat.Guid; Line 7: Line 8: public class AuditLogEvent { > AFAIK, We strive to decouple engine code from notifier code as much as poss Yes I did see that we already have a AuditLogEvent in tools, from what I see the class in tools does not have all the fields from the database for entity ids. Also equality of two AuditLogEvents in this logic is different from the one in tools. If we reuse the one in tools I will need to extend it and add extra variables and add methods to it. Line 9: Line 10: private Guid cmdId; Line 11: private AuditLogType auditLogType; Line 12: private Guid vdsGroupId; http://gerrit.ovirt.org/#/c/31639/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/CommandCoordinatorEventManager.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/bll/CommandCoordinatorEventManager.java: Line 8: /** Line 9: * Called from command callbacks to register for audit log events Line 10: * @param event Line 11: */ Line 12: public void registerForEvent(AuditLogEvent event); > This is what I understood from the commit msg. Yes the idea is that the callback will register and receive event notification not the command Line 13: Line 14: /** Line 15: * Raise an event when an audit log entry is logger in the database Line 16: * @param auditlog -- To view, visit http://gerrit.ovirt.org/31639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67e4c8f95dbe8c96a2e8d12c400ab922d16c81cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
