Tomas Jelinek has posted comments on this change. Change subject: webadmin: introduce storage qos ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/29530/16/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/QosModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/qos/QosModel.java: Line 37: } Line 38: Line 39: public boolean validate() { Line 40: getName().validateEntity(new IValidation[] { new NotEmptyValidation(), new AsciiNameValidation() }); Line 41: I think also the description needs validation: getDescription().validateEntity(new IValidation[] { new AsciiOrNoneValidation() }); Line 42: setIsValid(getIsValid() && getName().getIsValid()); Line 43: return getIsValid(); Line 44: } Line 45: -- To view, visit http://gerrit.ovirt.org/29530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d5c14409be9e1fad1df3487cf3615f4b4955930 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
