Allon Mureinik has posted comments on this change. Change subject: core,restapi: DirectLUN disk - validate LUN visibilty ......................................................................
Patch Set 1: (1 comment) Generally looks good. Please add tests for DiskValidator and AddDiskCommand http://gerrit.ovirt.org/#/c/31676/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java: Line 279: } Line 280: Line 281: @Override Line 282: public VDS getVds() { Line 283: setVdsId(getParameters().getVdsId()); This should be done in the ctor, IMHO. Line 284: return super.getVds(); Line 285: } Line 286: Line 287: @Override -- To view, visit http://gerrit.ovirt.org/31676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I339c999ebdfa69b8e2cbe4f55f8fe12e455810e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
