Oved Ourfali has posted comments on this change. Change subject: engine : CoCo: Set status at end of command execution ......................................................................
Patch Set 1: Code-Review+2 (1 comment) just add a comment http://gerrit.ovirt.org/#/c/31679/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1191: clearChildAsyncTasksWithOutVdsmId(); Line 1192: setCommandStatus(CommandStatus.FAILED); Line 1193: setSucceeded(false); Line 1194: compensate(); Line 1195: } else { add some comment here to make the logic more clear. Line 1196: if (getTaskType() == AsyncTaskType.notSupported && Line 1197: getReturnValue().getVdsmTaskIdList().isEmpty() && Line 1198: getCallBack() == null && Line 1199: commandStatus == CommandStatus.ACTIVE) { -- To view, visit http://gerrit.ovirt.org/31679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc3960568993baf888a3d9f74e7fad4bd0589823 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
