Arik Hadas has posted comments on this change. Change subject: core: update CPU QoS policy for running VMs ......................................................................
Patch Set 2: (2 comments) I would prefer to pass this info in the create verb so vdsm will do it right after the qemu process is lunched instead of having another call from the engine to vdsm. I understand that there was a discussion about this before, so for now I guess it is ok but I think it's something that should be reconsidered again. http://gerrit.ovirt.org/#/c/31631/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/CpuQosDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/CpuQosDaoDbFacadeImpl.java: Line 22: return map; Line 23: } Line 24: Line 25: @Override Line 26: public CpuQos getCpuQosByVmId(Guid vmId) { unit test is missing Line 27: MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() Line 28: .addValue("vm_id", vmId); Line 29: return getCallsHandler().executeRead("GetQosByVmId", Line 30: createEntityRowMapper(), Line 25: @Override Line 26: public CpuQos getCpuQosByVmId(Guid vmId) { Line 27: MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() Line 28: .addValue("vm_id", vmId); Line 29: return getCallsHandler().executeRead("GetQosByVmId", where GetQosByVmId is implemented? Line 30: createEntityRowMapper(), Line 31: parameterSource); Line 32: } Line 33: -- To view, visit http://gerrit.ovirt.org/31631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia762ef4fc26cbfa913c077d34da51a9fa44946e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
