Gilad Chaplik has posted comments on this change. Change subject: webadmin: introduce cpu QoS ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31626/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java: Line 309: @Provides Line 310: @Singleton Line 311: public SearchableDetailModelProvider<CpuQos, DataCenterListModel, DataCenterCpuQosListModel> getDataCenterCpuQosListProvider(EventBus eventBus, Line 312: Provider<DefaultConfirmationPopupPresenterWidget> defaultConfirmPopupProvider, Line 313: final Provider<CpuQosPopupPresenterWidget> CpuQosPopupProvider, > s/CpuQosPopupProvider/cpuQosPopupProvider Done Line 314: final Provider<RemoveConfirmationPopupPresenterWidget> removeConfirmPopupProvider) { Line 315: return new SearchableDetailTabModelProvider<CpuQos, DataCenterListModel, DataCenterCpuQosListModel>( Line 316: eventBus, defaultConfirmPopupProvider, Line 317: DataCenterListModel.class, http://gerrit.ovirt.org/#/c/31626/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java: Line 72: public static final String dataCenterStorageQosSubTabPlace = dataCenterMainTabPlace + SUB_TAB_PREFIX Line 73: + "storage_qos"; //$NON-NLS-1$ Line 74: Line 75: public static final String dataCenterCpuQosSubTabPlace = dataCenterMainTabPlace + SUB_TAB_PREFIX Line 76: + "Cpu_qos"; //$NON-NLS-1$ > for consistency reasons please do it with small C like: "cpu_qos" not intentional :) Done. Line 77: Line 78: public static final String dataCenterPermissionSubTabPlace = dataCenterMainTabPlace + SUB_TAB_PREFIX Line 79: + "permissions"; //$NON-NLS-1$ Line 80: -- To view, visit http://gerrit.ovirt.org/31626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66d2c322158fd05f3a6beabac71d28ca8b179a63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
