Ravi Nori has posted comments on this change.

Change subject: engine: Add AddVmTemplateCommand to command executer framework
......................................................................


Patch Set 3:

@Omer

setCommandStatus can be removed it is automatically taken case of by the 
AsyncTaskManager Framework

curently we are not persisting all commands so we need the persistCommand call. 
We are discussing other options for not having to invoke this manually (either 
by annotation or by persisting all commands). I will keep you posted.

-- 
To view, visit http://gerrit.ovirt.org/31180
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to