Martin Sivák has posted comments on this change. Change subject: Fixing vcpuCount periodic error. ......................................................................
Patch Set 1: (2 comments) I agree with one of the comments, but this patch is just a backport to stable branch. We should address the issue in master. This patch needs to go in to fix a potential blocker bug. http://gerrit.ovirt.org/#/c/30486/1/mom/HypervisorInterfaces/vdsmInterface.py File mom/HypervisorInterfaces/vdsmInterface.py: Line 181 Line 182 Line 183 Line 184 Line 185 > s/==/is/ You are right, but this is not part of this patch. Also this patch is intended to go to stable. We should fix this on master first. Line 184 Line 185 Line 186 Line 187 Line 188 > Come to think of it, this whole block is rather clumsy. How about this ins Well mixing the defaults and KeyError does not look much nicer to me. Especially when the try: might cause existing values to be omitted when someone accidentally removes the defaults in the future (because it is covered by the exception block, right?). -- To view, visit http://gerrit.ovirt.org/30486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie913a68b95f0384dbd573275cd9e70cb6c740ee6 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: mom-0.4.1 Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
