Arik Hadas has posted comments on this change. Change subject: core, db: disk profile: handle attach/detach ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/29037/14/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/profiles/DiskProfileDaoTest.java: Line 139: List<DiskProfile> allForStorageDomain = dao.getAllForStorageDomain(FixturesTool.STORAGE_DOAMIN_SCALE_SD5); Line 140: assertNotNull(allForStorageDomain); Line 141: assertFalse(allForStorageDomain.isEmpty()); Line 142: for (DiskProfile diskProfile : allForStorageDomain) { Line 143: allValues &= diskProfile.getQosId() == null; > there could null values (in first one). the test is for all values. I think that what Liron meant is that since you are calling this method only with isAllNull=true, you can remove the argument and assert that each of the disks is null, then you won't need to aggregate the results. Line 144: } Line 145: assertEquals(isAllNull, allValues); Line 146: } -- To view, visit http://gerrit.ovirt.org/29037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29aaf7b0b537f0b80b91b09e025e9487bbb69c2d Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
