anmolbabu has posted comments on this change.

Change subject: webadmin : Optimise for virt store on volumes
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/31041/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java:

Line 914:         List<GlusterVolumeOptionEntity> filteredOptions = 
volumeOptionsEnabled;
Line 915:         List<GlusterVolumeOptionEntity> tempFilteredOptions = 
volumeOptionsEnabled;
Line 916:         for(PredicateFilter<GlusterVolumeOptionEntity> predicate  : 
predicates) {
Line 917:              tempFilteredOptions = 
ListUtils.filter(volumeOptionsEnabled, predicate);
Line 918:              filteredOptions.retainAll(tempFilteredOptions);
> There is no change in the logic.
Ya correct got it.Will change it
Line 919:         }
Line 920:         if(filteredOptions.size() > 0) {
Line 921:             return true;
Line 922:         }


-- 
To view, visit http://gerrit.ovirt.org/31041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to