Alon Bar-Lev has posted comments on this change. Change subject: aaa: coverity fixes ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31569/2/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java: Line 523: Line 524: printSuccessMessage(domainName, "added"); Line 525: } else { Line 526: System.err.println("Provider typ was not provided. Use --providerType=<ldap_provider_type"); Line 527: } usually better to have trivial block first... also, if we have printSuccessMessage, don't we have printFailureMessage? Line 528: } Line 529: Line 530: private void setLdapServersPerDomain(String domainName, Line 531: DomainsConfigurationEntry ldapServersEntry, -- To view, visit http://gerrit.ovirt.org/31569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bb986dd9df608cac00f9387cfee7c84b65b2631 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
