Allon Mureinik has posted comments on this change. Change subject: core: Set image format correctly when creating template image on block domain ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/31635/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java: Line 106: * Line 107: * TODO: Extract method and unite with getVolumeFormatForDomain() in CopyImageGroupCommand Line 108: */ Line 109: private VolumeFormat getTargetVolumeFormat(VolumeFormat volumeFormat, VolumeType volumeType, Guid storageDomainId) { Line 110: if (volumeFormat == VolumeFormat.RAW && volumeType == VolumeType.Sparse) { // Please remove the trailing // Line 111: StorageDomainStatic destDomain = getStorageDomainStaticDAO().get(storageDomainId); Line 112: if (destDomain.getStorageType().isBlockDomain()) { Line 113: return VolumeFormat.COW; Line 114: } -- To view, visit http://gerrit.ovirt.org/31635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfa0843d3cad69682f6030ed47ec1699c106447a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
