Alon Bar-Lev has posted comments on this change.
Change subject: build: move /var structure creation from Makefile to spec
......................................................................
Patch Set 5:
> However I don't like the use of %{__install} instead of plain install, it
> makes the code a bit closer to Chinese than I would like it.
Please refer to other packages[1] in fedora, some I gave examples, they are
using %{} for almost everything, I think I will follow with the mv and other
variables people use.
[1]
http://pkgs.fedoraproject.org/gitweb/?p=tomcat6.git;a=blob;f=tomcat6.spec;h=6efbd37116767d6d0eadf46319252c0ecc703203;hb=HEAD#l288
--
To view, visit http://gerrit.ovirt.org/6258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib450429d4d6e5f5cbf0ae60bf3fb3baf6d5e5fb6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
