Eli Mesika has posted comments on this change. Change subject: engine: Report domain monitoring for virt nodes only ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31448/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 53: * @param vdsDomainData Line 54: */ Line 55: public static void updateVdsDomainsData(VDS vds, Guid storagePoolId, Line 56: ArrayList<VDSDomainsData> vdsDomainData) { Line 57: if (vds.getStatus() == reportingVdsStatus && vds.getVdsGroupSupportsVirtService()) { > Wouldn't this mean these check (status and virt host) needs to be repeated I see only one call of that from the VdsManager Line 58: IrsProxyData proxy = _irsProxyData.get(storagePoolId); Line 59: if (proxy != null) { Line 60: proxy.updateVdsDomainsData(vds.getId(), vds.getName(), vdsDomainData); Line 61: } -- To view, visit http://gerrit.ovirt.org/31448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8731a81de756cbe0bb221f205c2a6d50c015b86b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
