Vojtech Szocs has posted comments on this change. Change subject: webadmin: Show CanDoAction errors from HotPlugUnplugVmNic in UI ......................................................................
Patch Set 1: Thanks Greg for posting this patch. The general problem with LocalizedEnums (and any other ConstantsWithLookup subinterface) is that its message keys are not referenced directly (by calling its interface methods), but rather via the generic getString() method. Because of this, GWT compiler cannot verify message key/value existence during GWT compilation, and any errors regarding missing keys/values will show up during runtime. To prevent these kind of errors, we should validate all LocalizedEnums interface methods during project compilation, and fail the build in case they are not in sync with backend enums. This is planned to be done later on. -- To view, visit http://gerrit.ovirt.org/6250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5321e7c6c9865c9dae15a6f85ae52d747f5ee6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
