Allon Mureinik has posted comments on this change.

Change subject: core: Add memory allocation check to hibernate VM
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/30883/12/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java:

Line 175: 
Line 176:     private void initConfigUtils(Integer threshold) {
Line 177:         IConfigUtilsInterface configUtils = 
mock(IConfigUtilsInterface.class);
Line 178:         
when(configUtils.getValue(ConfigValues.FreeSpaceCriticalLowInGB, 
ConfigCommon.defaultConfigurationVersion)).thenReturn(threshold);
Line 179:         Config.setConfigUtils(configUtils);
should use MockConfigRule
Line 180:     }
Line 181: 
Line 182:     private static List<DiskImage> createDisks(int vmMemSizeInBytes) {
Line 183:         DiskImage memoryVolume = createDiskImage(false);


-- 
To view, visit http://gerrit.ovirt.org/30883
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to