anmolbabu has posted comments on this change.

Change subject: engine : Bll Command to Create Geo Rep session
......................................................................


Patch Set 9:

(2 comments)

http://gerrit.ovirt.org/#/c/29834/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepSessionCreateCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeGeoRepSessionCreateCommand.java:

Line 61: 
Line 62:     @Override
Line 63:     protected void executeCommand() {
Line 64:         String slaveHost = parameter.getSlaveNodeIp();
Line 65:         String slaveRootPassword = parameter.getSlavePassword();
> you can call this as 'slaveUserPassword'
Done
Line 66:         String slaveSShFingerPrint = 
GlusterUtil.getInstance().getHostSSHFingerPrint(slaveHost);
Line 67:         VDSReturnValue sessionCreateReturnValue = null;
Line 68:         VDSReturnValue passwordlessSSHCreateReturnValue = 
runVdsCommand(VDSCommandType.CreatePasswordLessSSHSession, new 
GlusterSshSessionParameters(slaveHost, slaveSShFingerPrint, 
parameter.getUserName(), parameter.getSlavePassword()));
Line 69:         if (passwordlessSSHCreateReturnValue.getSucceeded()) {


http://gerrit.ovirt.org/#/c/29834/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepParamater.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeGeoRepParamater.java:

Line 2: 
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4: 
Line 5: 
Line 6: public class GlusterVolumeGeoRepParamater extends 
GlusterVolumeParameters{
> GlusterVolumeGeoRepParamaters
Done
Line 7: 
Line 8:     private static final long serialVersionUID = 1L;
Line 9: 
Line 10:     //Master Volume id is volumeId of base class


-- 
To view, visit http://gerrit.ovirt.org/29834
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iccc92235deea42d7818336b2402476193cbe789c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to