Eli Mesika has posted comments on this change. Change subject: UI:Adding support for host with connectivity.. ......................................................................
Patch Set 14: (6 comments) http://gerrit.ovirt.org/#/c/31305/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 903 Line 904 Line 905 Line 906 Line 907 > not related. Done Line 794: Line 795: private ListModel<Integer> hostsWithBrokenConnectivityThreshold; Line 796: Line 797: public ListModel<Integer> getHostsWithBrokenConnectivityThreshold() Line 798: { > format Done Line 799: return hostsWithBrokenConnectivityThreshold; Line 800: } Line 801: Line 802: public void setHostsWithBrokenConnectivityThreshold(ListModel<Integer> value) Line 799: return hostsWithBrokenConnectivityThreshold; Line 800: } Line 801: Line 802: public void setHostsWithBrokenConnectivityThreshold(ListModel<Integer> value) Line 803: { > format Done Line 804: hostsWithBrokenConnectivityThreshold = value; Line 805: } Line 806: Line 807: public ClusterModel() Line 1592: ArrayList values = new ArrayList<Integer>(); Line 1593: // populating threshold values with {25, 50, 75, 100} Line 1594: for (int i = 25; i <= 100; i += 25) { Line 1595: values.add(i); Line 1596: } > maybe a config value is better, or at least a constant. This is not about to change since those are static percentage values so I see no reason for that Line 1597: getHostsWithBrokenConnectivityThreshold().setItems(values); Line 1598: } Line 1599: Line 1600: private void storagePool_SelectedItemChanged(EventArgs e) http://gerrit.ovirt.org/#/c/31305/14/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 379 Line 380 Line 381 Line 382 Line 383 > not related. Done Line 366: @Path(value = "skipFencingIfConnectivityBrokenEnabled.entity") Line 367: @WithElementId Line 368: EntityModelCheckBoxEditor skipFencingIfConnectivityBrokenCheckBox; Line 369: Line 370: @UiField(provided = true) > not sure it has to be provided since the rendered is pretty trivial. Leaving this to be in the safe side .... Line 371: @Path(value = "hostsWithBrokenConnectivityThreshold.selectedItem") Line 372: @WithElementId Line 373: ListModelListBoxEditor<Integer> hostsWithBrokenConnectivityThresholdEditor; Line 374: -- To view, visit http://gerrit.ovirt.org/31305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d300b37a49261744d81fd397772f70e56e7a688 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
