Alona Kaplan has posted comments on this change. Change subject: webadmin: The are no splitters in the Host>Interface header ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31288/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java: Line 194: public SafeHtml getValue() { Line 195: if (text != null) { Line 196: return templates.nonResizeableColumnHeader(text); Line 197: } Line 198: return null; > Does this mean that if there's no header text then the border won't be show To represent a no-text header we pass empty string and not null value. As a matter of fact, we can't get here with null text, we'll have a NPE much earlier. So this safety check can be removed, although I think it is harmful. Line 199: } Line 200: }; Line 201: } Line 202: -- To view, visit http://gerrit.ovirt.org/31288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb276a805508b5f2729f609ec2861504a561acea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
