Juan Hernandez has posted comments on this change.
Change subject: build: pass directories and utilities from spec to Makefile
......................................................................
Patch Set 5: (11 inline comments)
....................................................
File Makefile
Line 27: PACKAGE_NAME=ovirt-engine
I would suggest to use here two different variables: ENGINE_NAME that will
amost alwasy be "ovirt-engine" and PACKAGE_NAME that can change for different
distributions. Most of the directories should be named after ENGINE_NAME, as we
don't want to change the names of the directories in different distributions.
Line 32: DATA_DIR=$(DATAROOT_DIR)/$(PACKAGE_NAME)
This, for example, should be $(DATAROOT_DIR)/$(ENGINE_NAME) in my opinion.
Line 347: install -dm 755
$(DESTDIR)$(DATA_DIR)/modules/org/postgresql/main
$(DESTDIR)$(PKG_JBOSS_MODULES)/org/postgresql/main ?
Line 349: ln -s $(JAVA_DIR)/postgresql-jdbc.jar
$(DESTDIR)$(DATA_DIR)/modules/org/postgresql/main/.
$(DESTDIR)$(PKG_JBOSS_MODULES)/org/postgresql/main ?
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 15: %global engine_lock %{_localstatedir}/lock/%{engine_name}
I don't understand the benefit of renaming all this globals or using
_localstatedir instead of _var. It certainly makes things i bit harder for me.
Line 602: %{_mavenpomdir}/JPP.%{engine_name}-utils.pom
According to the Fedora packaging guidelines the names of the POMs should start
with JPP.%{name}. See https://fedoraproject.org/wiki/Packaging:Java#maven3.
Line 632: %{_mavenpomdir}/JPP.%{engine_name}-vdsbroker.pom
According to the Fedora packaging guidelines the names of the POMs should start
with JPP.%{name}.
Line 728: %{_mavenpomdir}/JPP.%{engine_name}-restapi-types.pom
According to the Fedora packaging guidelines the names of the POMs should start
with JPP.%{name}.
Line 741: %{_mavenpomdir}/JPP.%{engine_name}-genericapi.pom
According to the Fedora packaging guidelines the names of the POMs should start
with JPP.%{name}.
Line 763: %{_mavenpomdir}/JPP.%{engine_name}-engine-tools-common.pom
According to the Fedora packaging guidelines the names of the POMs should start
with JPP.%{name}.
Line 809: %{_mavenpomdir}/JPP.%{engine_name}-engine-notifier.pom
According to the Fedora packaging guidelines the names of the POMs should start
with JPP.%{name}.
--
To view, visit http://gerrit.ovirt.org/6252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I78708f7bdc4cbcdfc736210821a05cfd1800f234
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
