Daniel Erez has posted comments on this change. Change subject: webadmin: introduce disk profiles ......................................................................
Patch Set 12: Code-Review+2 (4 comments) http://gerrit.ovirt.org/#/c/29672/12//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-08-14 11:06:12 +0300 Line 6: Line 7: webadmin: introduce disk profiles Line 8: Line 9: * disk profiles subtab under storage main tab. please format the commit message.. Line 10: Shows disk profiles attached to selected storage domain. Line 11: * create/update/remove dialog disk profile. Line 12: Allows to invoke all disk profiles associated actions, from disk profiles subtab Line 13: * backend integration in GUI. Line 11: * create/update/remove dialog disk profile. Line 12: Allows to invoke all disk profiles associated actions, from disk profiles subtab Line 13: * backend integration in GUI. Line 14: Line 15: For more information see http://www.ovirt.org/Features/blkio-support please add screenshots to the wiki page Line 16: Line 17: Change-Id: Ibe5cea3c563cf68efca0468749338a532894f709 http://gerrit.ovirt.org/#/c/29672/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/DiskProfileListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/DiskProfileListModel.java: Line 118: new AsyncQuery(new INewAsyncCallback() { Line 119: @Override Line 120: public void onSuccess(Object model, Object returnValue) { Line 121: List<StorageQos> qosList = Line 122: (ArrayList<StorageQos>) ((VdcQueryReturnValue) returnValue).getReturnValue(); please check if there's any redundant casting Line 123: qosMap = new HashMap<Guid, StorageQos>(); Line 124: if (qosList != null) { Line 125: for (StorageQos storageQos : qosList) { Line 126: qosMap.put(storageQos.getId(), storageQos); Line 138: new AsyncQuery(new INewAsyncCallback() { Line 139: Line 140: @Override Line 141: public void onSuccess(Object model1, Object returnValue1) { Line 142: DiskProfileListModel.this.setItems((List<DiskProfile>) ((VdcQueryReturnValue) returnValue1).getReturnValue()); please check if there's any redundant casting Line 143: } Line 144: })); Line 145: } Line 146: -- To view, visit http://gerrit.ovirt.org/29672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5cea3c563cf68efca0468749338a532894f709 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
