Alon Bar-Lev has posted comments on this change. Change subject: engine, webadmin: Webadmin read reports.xml from remote reports app ......................................................................
Patch Set 22: (6 comments) Looks great! http://gerrit.ovirt.org/#/c/29723/22/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java: Line 25: Line 26: private static final ReportInit INSTANCE = new ReportInit(); Line 27: private static final int MAX_RETRY_COUNTS = 20; Line 28: private static final int RETRY_INTERVAL = 30000; Line 29: public static final String ReportRedirectService = "/ovirt-engine/services/reports-redirect"; //$NON-NLS-1$ how come this has /ovirt-engine/ while the bellow not? I think the root part should be dynamically obtained. Line 30: public static final String ReportStatusService = "services/reports-proxy?command=status"; //$NON-NLS-1$ Line 31: public static final String ReportXmlService = "services/reports-proxy?command=webadmin-ui-xml"; //$NON-NLS-1$ Line 32: private int retryCount; Line 33: private boolean reportsWebappDeployed; http://gerrit.ovirt.org/#/c/29723/22/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabReportsView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabReportsView.java: Line 24 Line 25 Line 26 Line 27 Line 28 unrelated http://gerrit.ovirt.org/#/c/29723/22/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 543 Line 544 Line 545 Line 546 Line 547 don't you need to remove it? http://gerrit.ovirt.org/#/c/29723/22/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 213: # Line 214: # Reports Line 215: # by default serv 404. Line 216: # Line 217: ENGINE_REPORTS_COMMAND_INTERFACE_URL= this should be the base url for the entire reports, not only command interface? Line 218: ENGINE_REPORTS_DASHBOARD_URL=${ENGINE_REPORTS_COMMAND_INTERFACE_URL}/flow.html?viewAsDashboardFrame=true Line 219: ENGINE_REPORTS_PROXY_URL=${ENGINE_REPORTS_COMMAND_INTERFACE_URL}/ReportsProxy Line 220: Line 221: Line 214: # Reports Line 215: # by default serv 404. Line 216: # Line 217: ENGINE_REPORTS_COMMAND_INTERFACE_URL= Line 218: ENGINE_REPORTS_DASHBOARD_URL=${ENGINE_REPORTS_COMMAND_INTERFACE_URL}/flow.html?viewAsDashboardFrame=true the flow is jasper's, right? so it is not command interface. if it is the interface, and it is a servlet, please call it properly... not flow.html.... as this servlet should redirect into jasper, right? Line 219: ENGINE_REPORTS_PROXY_URL=${ENGINE_REPORTS_COMMAND_INTERFACE_URL}/ReportsProxy Line 220: Line 221: Line 215: # by default serv 404. Line 216: # Line 217: ENGINE_REPORTS_COMMAND_INTERFACE_URL= Line 218: ENGINE_REPORTS_DASHBOARD_URL=${ENGINE_REPORTS_COMMAND_INTERFACE_URL}/flow.html?viewAsDashboardFrame=true Line 219: ENGINE_REPORTS_PROXY_URL=${ENGINE_REPORTS_COMMAND_INTERFACE_URL}/ReportsProxy the remote should not be called proxy :) or I do not understand what this does... I would assume that we install a /ovirt at reports side for ovirt specific stuff, and have /ovirt/xxx for our interface. Line 220: Line 221: -- To view, visit http://gerrit.ovirt.org/29723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
