Ravi Nori has uploaded a new change for review. Change subject: engine : Failed commands should not be set to Failed restarted ......................................................................
engine : Failed commands should not be set to Failed restarted When a command has failed due to an exception n executeCommand method the status of the command is set to FAILED and the execute flag is false. If the server is restarted before the callback is the status of the command should not be set to FAILED_RESTARTED and the callback's onFailed should called after restart Change-Id: I9d00ea9d29acfa4894595a978a8376a530c2fc8d Bug-Url: https://bugzilla.redhat.com/1129885 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/31540/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java index 7322c8b..bc535ed 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java @@ -116,7 +116,7 @@ private void initCommandExecutor() { if (!cmdExecutorInitialized) { for (CommandEntity cmdEntity : coco.getCommandsWithCallBackEnabled()) { - if (!cmdEntity.isExecuted()) { + if (!cmdEntity.isExecuted() && cmdEntity.getCommandStatus() != CommandStatus.FAILED) { coco.retrieveCommand(cmdEntity.getId()).setCommandStatus(CommandStatus.FAILED_RESTARTED); } else if (!cmdEntity.isCallBackNotified()) { addToCallBackMap(cmdEntity); -- To view, visit http://gerrit.ovirt.org/31540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d00ea9d29acfa4894595a978a8376a530c2fc8d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
