Frank Kobzik has posted comments on this change. Change subject: core: Detect inability to decrypt password in RunOnce ......................................................................
Patch Set 4: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/31387/4/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/DomainsPasswordMap.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/DomainsPasswordMap.java: Line 14: private I'd like to know opinions of others to this one. I don't like this solution very much. The thing is we must have some way to determine whether the password was decrypted correctly and this is probably easiest way. -- To view, visit http://gerrit.ovirt.org/31387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37760cce844f394e480d712e6ed024f22b848348 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
