Vojtech Szocs has posted comments on this change. Change subject: webadmin: Add option disable fencing in cluster ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31256/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 771: getOptimizationCustom_IsSelected().setEntity(true); Line 772: } Line 773: } Line 774: Line 775: private EntityModel<Boolean> fencingEnabledModel; > Well, here it's not that visible, but without mode suffix line 1257 would b I agree, it can be confusing. I am also OK with "Model" suffix. Line 776: Line 777: public EntityModel<Boolean> getFencingEnabledModel() { Line 778: return fencingEnabledModel; Line 779: } -- To view, visit http://gerrit.ovirt.org/31256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd373c344e767306526b2af3955c2d0d33027736 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
