Lior Vernia has uploaded a new change for review. Change subject: webadmin: Don't trigger event when assigning label ......................................................................
webadmin: Don't trigger event when assigning label Since we're only mocking another operation to assign a label to a NIC, the code is changed to not trigger an event (that would affect the status panel). Change-Id: I676ddff5293d1a7e22a911bb3b03e6da6707c493 Bug-Url: https://bugzilla.redhat.com/1115109 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/17/31517/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java index 4315e15..3c1355d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java @@ -295,11 +295,11 @@ mockDst.setEntity(new VdsNetworkInterface()); mockDst.setItems(new ArrayList<LogicalNetworkModel>(potentialNetworks)); - boolean res = candidateOperation(mockSrc, mockDst, false); - if (!res) { + boolean valid = !NetworkOperationFactory.operationFor(mockSrc, mockDst).isNullOperation(); + if (!valid) { candidateOperation(mockSrc, mockDst, true); // trick to get a red-highlighted error status } - return res; + return valid; } private void commitLabelChanges(NicLabelModel labelModel, -- To view, visit http://gerrit.ovirt.org/31517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I676ddff5293d1a7e22a911bb3b03e6da6707c493 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
