Oved Ourfali has submitted this change and it was merged.

Change subject: core: maxVCpus revised
......................................................................


core: maxVCpus revised

we need to make sure must be result of cores * socket otherwise the VM
will fail to load by libvirt

for:
c  = 12 // cores
maxSocket = 16 //config
maxVCpu = 160 // config

maxVCpu = c * (min(maxSockets, maxVCpu / c)) // 12 * 13 = 156

prior to this fix vdsm would end up with

<vcpu current=12>160</vcpu>
<topology cores=12 socket=13 thread=1>

and 160 couldn't be fulfilled by cores * socket, 156

Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4
Bug-Url: https://bugzilla.redhat.com/1126797
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
1 file changed, 12 insertions(+), 8 deletions(-)

Approvals:
  Roy Golan: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2880c0a1523bf5c4a6b5144860efafb6df82deb4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to