Alona Kaplan has posted comments on this change. Change subject: webadmin: Validate no duplicate network names on import ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/30650/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java: Line 216: nameToIndex.put(networkName, i); Line 217: } Line 218: Line 219: // invalidate current entry Line 220: errors.add(encounteredIndex == null ? null : errorDuplicate); This line seems to be a bug. Line 221: ++i; Line 222: } Line 223: getErrors().setItems(errors); Line 224: return valid; -- To view, visit http://gerrit.ovirt.org/30650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If63d450bfc8d666ebb383e29fdfe43fcf879db78 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
