Sandro Bonazzola has posted comments on this change.

Change subject: Adding support for ovirt-ha-agent status
......................................................................


Patch Set 2: Verified-1

./__main__.py:765:80: E501 line too long (97 > 79 characters)
 ./__main__.py:1341:80: E501 line too long (108 > 79 characters)
 ./__main__.py:1344:5: E303 too many blank lines (2)

Other than that, I would really prefer to use a sos plugin and get all relevant 
data.
Commented on the BZ.

-- 
To view, visit http://gerrit.ovirt.org/31269
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43c14112df2e15289f5aac1c302eeafc011ed9ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Wallace Daniel <wdan...@redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Wallace Daniel <wdan...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to