Yair Zaslavsky has posted comments on this change. Change subject: aaa: AuthzUtils and legacy provider support fetchPrincipalRecord changes ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31413/4/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthzUtils.java: Line 308: } Line 309: return results; Line 310: } Line 311: Line 312: private static ExtMap fetchPrincipalRecordImpl(final ExtensionProxy extension, ExtMap input) { > I might... :) why not? that's the beauty of ExtMap, no? in one case it will contain the auth record, in another case it will contain the principal string... without that private one I will have repeating code in the two public ones.. Line 313: ExtMap ret = null; Line 314: ExtMap output = extension.invoke(input); Line 315: if (output.<Integer> get(Authz.InvokeKeys.STATUS) == Authz.Status.SUCCESS) { Line 316: ret = output.<ExtMap> get(Authz.InvokeKeys.PRINCIPAL_RECORD); -- To view, visit http://gerrit.ovirt.org/31413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ba5d75449afd1ecdf75e7b335b4ab5cb32d10ce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
