Alon Bar-Lev has posted comments on this change. Change subject: extapi: Changing fetch principal to support principal ......................................................................
Patch Set 4: (3 comments) please squash to actual usage, there is no sense in doing that separately. http://gerrit.ovirt.org/#/c/31412/4/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java: Line 200 Line 201 Line 202 Line 203 Line 204 please add PRINCIPAL here as well, note that it is output only Line 112: * Fetch principal record. Line 113: * Used for user login. Line 114: * Line 115: * <p> Line 116: * Input: Either one of the following: to not confuse with other future inputs, please do not put the above note here. Line 117: * <ul> Line 118: * <li>{@link Authn.InvokeKeys#AUTH_RECORD}[O] - authentication record.</li> Line 119: * <li>{@link Authz.InvokeKeys#PRINCIPAL}[O] - principal.</li> Line 120: * </ul> Line 115: * <p> Line 116: * Input: Either one of the following: Line 117: * <ul> Line 118: * <li>{@link Authn.InvokeKeys#AUTH_RECORD}[O] - authentication record.</li> Line 119: * <li>{@link Authz.InvokeKeys#PRINCIPAL}[O] - principal.</li> principal name if auth record is not available Line 120: * </ul> Line 121: * </p> Line 122: * Line 123: * <p> -- To view, visit http://gerrit.ovirt.org/31412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea9aecf0c5c95c76e61b400e04808114bcf15095 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
