Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: iscsi: add multiple lun per target support ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31398/1/src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py File src/plugins/ovirt-hosted-engine-setup/storage/iscsi.py: Line 250: for device in devices['devList']: Line 251: for path in device['pathlist']: Line 252: if path['iqn'] == iqn: Line 253: iscsi_lun_list.append(device) Line 254: iqn_found = True > how about break here? otherwise you're going to time.sleep() few line later can't break here, otherwise I won't add all the luns but just the first. I'll skip the sleep. Line 255: if not iqn_found: Line 256: self.logger.info('Discovering iSCSI node') Line 257: self._iscsi_discovery( Line 258: ip, -- To view, visit http://gerrit.ovirt.org/31398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b00cc09754a8b95bc1497e0f769ae2a9c64f1b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
