Vojtech Szocs has posted comments on this change.

Change subject: doc: Describe 'gwt.cssResourceStyle' in README.developer
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/31342/1/README.developer
File README.developer:

Line 146:     DEV_EXTRA_BUILD_FLAGS="-Dgwt.compiler.localWorkers=2"
Line 147: 
Line 148:     For easier frontend development and debugging, prevent
Line 149:     GWT compiler from obfuscating generated CSS class names:
Line 150:     DEV_EXTRA_BUILD_FLAGS="-Dgwt.cssResourceStyle=pretty"
> don't you like to add this to DEV_BUILD_GWT_DRAFT? or add some other key li
Good idea.

I can make GWT CSS de-obfuscation setting to be part of DEV_BUILD_GWT_DRAFT.

I'll update this patch accordingly.
Line 151: 
Line 152: DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS [-D gwt.userAgent=gecko1_8]
Line 153:     By default, only the gecko1_8 (Mozilla Firefox) support is built,
Line 154:     building all permutations is possible by specifying


-- 
To view, visit http://gerrit.ovirt.org/31342
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I143d204d2f77e1e4350787c8ba46f61d4700f361
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to