Xiaolei Shi has posted comments on this change. Change subject: core: Avoid starting vm failed if pin to host is removed ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/28166/10//COMMIT_MSG Commit Message: Line 8: Line 9: If the vm configured vm numa nodes and pinned them to host numa nodes, Line 10: when the host was removed,the pinned host numa nodes would be removed Line 11: also. Now if you try to run the vm, it would fail. This patch will Line 12: avoid this situation. > sorry for joining in late, I'm trying to understand why delete cascade won' Delete cascade works, it will set the pinned node id to null, keep the pinned node index. In previous codes, it didn't check the id null and will cause a exception, this patch is to fix the issue. As we talked before, when vm do migration, once the migrated-to host is selected, we will have a action to update the pinned node id, now we don't have this action, so need to add a check here. Line 13: Line 14: Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c Line 15: Bug-Url: https://bugzilla.redhat.com/1101387 -- To view, visit http://gerrit.ovirt.org/28166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbbfd981d0996689cdc818bdd02e31155799d55c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
