Shahar Havivi has posted comments on this change. Change subject: engine: Add AddVmTemplateCommand to command executer framework ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31180/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 693: p, Line 694: cloneContextAndDetachFromParent()); Line 695: } Line 696: Line 697: if (TaskManagerUtil.getCommandExecutionStatus(getParameters().getCommandId()) == CommandExecutionStatus.EXECUTED) { > After discussing with Oved, this will change. If an exception is thrown the Great, I will wait for the patch and submit that one after. Line 698: // if template exist in db remove it Line 699: if (getVmTemplate() != null) { Line 700: DbFacade.getInstance().getVmTemplateDao().remove(getVmTemplateId()); Line 701: removeNetwork(); -- To view, visit http://gerrit.ovirt.org/31180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib47982264f535dcf38cd4f9319f842d75ebccd5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
